Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(example): check and extend refresh token expiration #698

Merged
merged 5 commits into from
Feb 13, 2025
Merged

docs(example): check and extend refresh token expiration #698

merged 5 commits into from
Feb 13, 2025

Conversation

mqf20
Copy link
Contributor

@mqf20 mqf20 commented Jan 27, 2025

Description

This PR updates the example code.

It checks that refresh tokens are not expired and extends their expiration times accordingly.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@muhlemmer muhlemmer self-requested a review January 29, 2025 10:39
@muhlemmer
Copy link
Collaborator

@mqf20 Thanks for contributing a series of PRs. I'll be reviewing them shortly. As a general comment for all the open PRs, can you please take note of our contributing guidelines regarding PR titles and edit the PR titles accordingly.

For example for this PR, change:

check and extend refresh token expiration in example

To

docs(example): check and extend refresh token expiration

This is needed for our semantic releaser.

Thanks in advance.

@muhlemmer muhlemmer mentioned this pull request Jan 30, 2025
Merged
@muhlemmer muhlemmer added the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label Jan 30, 2025
This was referenced Jan 30, 2025
Merged
Merged
@mqf20
Copy link
Contributor Author

mqf20 commented Jan 31, 2025

Sorry for overlooking the the contributing guidelines, will fix the PRs

@muhlemmer muhlemmer changed the title check and extend refresh token expiration in example docs(example): check and extend refresh token expiration Feb 13, 2025
@mqf20
Copy link
Contributor Author

mqf20 commented Feb 13, 2025

Sorry for the delay, let me resolve this

@muhlemmer muhlemmer removed the waiting For some reason, this issue will have to wait. This can be a feedback that is being waited for, a de label Feb 13, 2025
@muhlemmer muhlemmer enabled auto-merge (squash) February 13, 2025 11:47
@muhlemmer muhlemmer merged commit b1e5aca into zitadel:main Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer muhlemmer approved these changes

Assignees
No one assigned
Labels
os-contribution
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqf20 @muhlemmer @hifabienne